rdblue commented on a change in pull request #1586:
URL: https://github.com/apache/iceberg/pull/1586#discussion_r511162132
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -72,13 +72,19 @@ public HiveCatalog(Configuration conf) {
}
public HiveCatalog(String name, String uri, int clientPoolSize,
Configuration conf) {
+ this(name, uri, null, clientPoolSize, conf);
+ }
+
+ public HiveCatalog(String name, String uri, String warehouse, int
clientPoolSize, Configuration conf) {
this.name = name;
this.conf = new Configuration(conf);
// before building the client pool, overwrite the configuration's URIs if
the argument is non-null
if (uri != null) {
this.conf.set(HiveConf.ConfVars.METASTOREURIS.varname, uri);
}
-
+ if (warehouse != null) {
+ this.conf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname, warehouse);
Review comment:
I think handling this the same way that we handle the URI makes sense.
We set the URI because we need to pass it back into Hive to connect, which I
don't think applies to the warehouse path, but handling both the same way is
reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
