openinx commented on a change in pull request #1586:
URL: https://github.com/apache/iceberg/pull/1586#discussion_r509854267
##########
File path: flink/src/test/java/org/apache/iceberg/flink/FlinkTestBase.java
##########
@@ -34,23 +40,53 @@
private static TestHiveMetastore metastore = null;
protected static HiveConf hiveConf = null;
protected static HiveCatalog catalog = null;
- protected static ConcurrentMap<String, Catalog> flinkCatalogs;
+
+ private volatile TableEnvironment tEnv = null;
@BeforeClass
public static void startMetastore() {
FlinkTestBase.metastore = new TestHiveMetastore();
- metastore.start();
+ metastore.start(15);
Review comment:
I thought the hive handlers were not enough in the
`TestFlinkCatalogDatabase` test suite, but today I checked the logs carefully,
it's indeed a connection leak issue. The catalog connection would be closed
only when unregistering the catalog, means executing the sql `DROP CATALOG
test_catalog`. I found we did not release the connection after a test case
finished. No need to increase the handler number here, just need to provide
`Before/After` to create/release connection, pls see
https://github.com/apache/iceberg/pull/1586/commits/f2740c6cf4f7aa5e090a4b3df60e853aaa140e38.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
