rdblue commented on a change in pull request #1587:
URL: https://github.com/apache/iceberg/pull/1587#discussion_r511181217
##########
File path:
spark2/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -133,16 +135,29 @@ protected Table findTable(DataSourceOptions options,
Configuration conf) {
Optional<String> path = options.get("path");
Preconditions.checkArgument(path.isPresent(), "Cannot open table: path is
not set");
- if (path.get().contains("/")) {
- HadoopTables tables = new HadoopTables(conf);
- return tables.load(path.get());
+ if (nessie(options.asMap(), conf)) {
Review comment:
This is probably an area to revisit. Right now, this is written to have
minimal changes between 2.4.x and 3.0.x, but I think we will probably want to
route all loading from here through a catalog. That will allow us to delegate
all of this to Nessie or Hive the same way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
