rdblue commented on a change in pull request #1587:
URL: https://github.com/apache/iceberg/pull/1587#discussion_r511181610
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -103,6 +106,10 @@ protected Catalog buildIcebergCatalog(String name,
CaseInsensitiveStringMap opti
String warehouseLocation = options.get("warehouse");
return new HadoopCatalog(name, conf, warehouseLocation);
+ case "nessie":
+ String defaultBranch = options.getOrDefault("nessie_ref", "main");
+ String nessieUrl = options.get("nessie_url");
+ return new NessieCatalog(name, conf, defaultBranch, nessieUrl);
Review comment:
Please have a look at #1640, I'd like to standardize how we do this. I
do like using `type = nessie`, so we may want to have a lookup that points to
the `NessieCatalog` implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
