nastra commented on code in PR #14226:
URL: https://github.com/apache/iceberg/pull/14226#discussion_r2409729868
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -354,8 +382,10 @@ public void testManifestRewriteAndIncrementalCopy() throws
Exception {
checkFileNum(1, 1, addedManifest, 3, postReweiteResult);
}
- @Test
- public void testDeleteDataFile() throws Exception {
+ @ParameterizedTest
Review Comment:
rather than parameterizing every single method, we typically parameterize at
the class level by using `@ExtendWith(ParameterizedTestExtension.class)`. You
can take at a few other test classes that already do this, such as
`TestRewritePositionDeleteFilesAction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
