nastra commented on code in PR #14226:
URL: https://github.com/apache/iceberg/pull/14226#discussion_r2409715269
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -111,10 +114,23 @@ protected ActionsProvider actions() {
@BeforeEach
public void setupTableLocation() {
this.tableLocation = tableDir.toFile().toURI().toString();
- this.table = createATableWith2Snapshots(tableLocation);
createNameSpaces();
}
+ protected void setupTable() {
+ this.table = createATableWith2Snapshots(tableLocation);
+ }
+
+ protected void setupTableWithFormatVersion(int version) {
Review Comment:
these methods aren't needed because there's already a way to pass the
properties when creating a table. Personally I would remove
`createATableWith2Snapshots()` and use `createTableWithSnapshots()`, which
takes a properties map. Therefore you could just pass the properties in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
