pvary commented on code in PR #14353:
URL: https://github.com/apache/iceberg/pull/14353#discussion_r2438683054


##########
data/src/test/java/org/apache/iceberg/TestMergingMetrics.java:
##########
@@ -105,7 +104,7 @@ public abstract class TestMergingMetrics<T> {
           MAP_FIELD_2,
           STRUCT_FIELD);
 
-  protected abstract FileAppender<T> writeAndGetAppender(List<Record> records) 
throws Exception;
+  protected abstract DataFile writeAndGetDataFile(List<Record> records) throws 
Exception;

Review Comment:
   Because of this change, we need to commit Spark 3.4/3.5, Flink 2.0/1.20 
together, as all of them uses this as a base test. The other Spark and Flink 
versions are clean backports



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to