pvary commented on code in PR #14353:
URL: https://github.com/apache/iceberg/pull/14353#discussion_r2438686484
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/reader/ReaderUtil.java:
##########
@@ -46,36 +47,26 @@
import org.apache.iceberg.flink.source.DataIterator;
import org.apache.iceberg.flink.source.RowDataFileScanTaskReader;
import org.apache.iceberg.hadoop.HadoopFileIO;
-import org.apache.iceberg.io.FileAppender;
-import org.apache.iceberg.io.FileAppenderFactory;
+import org.apache.iceberg.io.DataWriter;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
public class ReaderUtil {
private ReaderUtil() {}
public static FileScanTask createFileTask(
- List<Record> records,
- File file,
- FileFormat fileFormat,
- FileAppenderFactory<Record> appenderFactory)
- throws IOException {
- FileAppender<Record> appender =
- appenderFactory.newAppender(Files.localOutput(file), fileFormat);
- try {
- appender.addAll(records);
- } finally {
- appender.close();
+ List<Record> records, File file, FileFormat fileFormat, Schema schema)
throws IOException {
Review Comment:
instead of the factory as an input, we create the factory internally using
the schema information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
