talatuyarer opened a new pull request, #14215:
URL: https://github.com/apache/iceberg/pull/14215
I noticed that `CatalogTests.java` didn't have any tests covering the new
branch and tag management features. I went ahead and added a comprehensive
suite to make sure the behavior is solid and to prevent any future regressions.
Basically, I've covered the entire lifecycle for both branches and tags:
* **Basic Lifecycle:** Creating, replacing/updating, and deleting branches
and tags. This includes creating them from the current `HEAD` or from an older,
specific snapshot.
* **Isolation:** Making sure that committing to one branch doesn't affect
`main` or any other branches. Also confirms that tags stay put and don't move
when `main` gets new commits.
* **Retention Policies:** Checking that the automatic cleanup logic works.
For example, ensuring old snapshots on a branch get purged correctly and that
tags expire when they're supposed to.
* **Error Handling:** I added tests for all the common "oops" scenarios,
like:
* Trying to create a branch/tag that already exists.
* Trying to remove a ref that isn't there.
* Making sure you can't delete the `main` branch.
* Using a bogus snapshot ID.
This should give us good coverage for the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
