nastra commented on code in PR #14215:
URL: https://github.com/apache/iceberg/pull/14215#discussion_r2394257892
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -3167,6 +3172,412 @@ public void testRegisterExistingTable() {
assertThat(catalog.dropTable(identifier)).isTrue();
}
+ @Test
+ public void testBranchLifecycleManagement() {
Review Comment:
I would prefer if we could split this up into multiple smaller test methods
that are more targeted instead of one large test method. This is also how the
already existing tests are being done in the catalog tests and this makes it
much easier to reason about tests.
Having a large test forces you to go through the entire test just to
understand what's happening and what's expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
