HeartLinked commented on code in PR #206:
URL: https://github.com/apache/iceberg-cpp/pull/206#discussion_r2371390837
##########
src/iceberg/expression/literal.h:
##########
@@ -71,6 +74,11 @@ class ICEBERG_EXPORT Literal {
static Literal Double(double value);
static Literal String(std::string value);
static Literal Binary(std::vector<uint8_t> value);
+ static Literal Fixed(std::vector<uint8_t> value);
+
+ /// \brief Factory methods for decimal type
+ static Literal Decimal(const Decimal& value, int32_t precision, int32_t
scale);
Review Comment:
I don't understand what you're saying. Both of these methods were just added
by me. The reason I added them is that I noticed our wrapper class, Decimal,
has clearer semantics. These two methods not only support the complete Decimal
type but also are intended to conveniently support the original int128_t type.
So, is your comment suggesting that the constructor using int128_t is
unnecessary, and we only need one new constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
