HuaHuaY commented on code in PR #206:
URL: https://github.com/apache/iceberg-cpp/pull/206#discussion_r2371280533
##########
src/iceberg/expression/literal.h:
##########
@@ -71,6 +74,11 @@ class ICEBERG_EXPORT Literal {
static Literal Double(double value);
static Literal String(std::string value);
static Literal Binary(std::vector<uint8_t> value);
+ static Literal Fixed(std::vector<uint8_t> value);
+
+ /// \brief Factory methods for decimal type
+ static Literal Decimal(const Decimal& value, int32_t precision, int32_t
scale);
Review Comment:
Will it be better to use `Decimal` in `Value` instead of `int128_t` and
remove the second overload function of `Decimal`? We already have the wrapper
class `Decimal` and it has clearer semantics.
And I think it's better to use this signature `Decimal(Decimal value,
int32_t precision, int32_t scale)` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
