dimas-b commented on code in PR #14196:
URL: https://github.com/apache/iceberg/pull/14196#discussion_r2389534471


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1966,6 +2026,15 @@ components:
               "GET /v1/{prefix}/namespaces/{namespace}/tables/{table}",
               "GET /v1/{prefix}/namespaces/{namespace}/views/{view}"
             ]
+        idempotencyKeyLifetime:
+          type: string
+          format: duration
+          description: >
+            Minimum retention window for Idempotency-Key tokens (ISO-8601 
duration,

Review Comment:
   "Minimum retention" is not very useful from the client's perspective, IMHO. 
The client needs to decide when if can reuse a previous key for retries, but 
"minimum retention" sounds like something for the server.
   
   How about `Maximum time period when the client can reuse a previous 
Idempotency-Key value. It is measured from the first request submission time 
using the key value to the submission time of the last retry (according to the 
client's clock). Servers should include some grace period into this time window 
to compensate for network delays and clock drift. Presence [...]` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to