kevinjqliu commented on code in PR #14196:
URL: https://github.com/apache/iceberg/pull/14196#discussion_r2429798638
##########
open-api/rest-catalog-open-api.py:
##########
@@ -65,6 +65,12 @@ class CatalogConfig(BaseModel):
'GET /v1/{prefix}/namespaces/{namespace}/views/{view}',
],
)
+ idempotency_key_lifetime: Optional[timedelta] = Field(
+ None,
+ alias='idempotency-key-lifetime',
+ description='Client reuse window for an Idempotency-Key (ISO-8601
duration, e.g., PT30M, PT24H). Interpreted as the maximum time from the first
submission using a key to the last retry during which a client may reuse that
key. Servers SHOULD accept retries for at least this duration and MAY include a
grace period to account for delays/clock skew. Clients SHOULD NOT reuse an
Idempotency-Key after this window elapses; they SHOULD generate a new key for
any subsequent attempt. Presence of this field indicates the server supports
Idempotency-Key semantics for mutation endpoints. If absent, clients MUST
assume idempotency is not supported.\n',
Review Comment:
nit
```suggestion
description='Client reuse window for an Idempotency-Key (ISO-8601
duration, e.g., PT30M, PT24H). Interpreted as the maximum time from the first
submission using a key to the last retry during which a client may reuse that
key. Servers SHOULD accept retries for at least this duration and MAY include a
grace period to account for delays/clock skew. Clients SHOULD NOT reuse an
Idempotency-Key after this window elapses; they SHOULD generate a new key for
any subsequent attempt. Presence of this field indicates the server supports
Idempotency-Key semantics for mutation endpoints. If absent, clients MUST
assume idempotency is not supported.',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
