adutra commented on code in PR #14178:
URL: https://github.com/apache/iceberg/pull/14178#discussion_r2376450995


##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##########
@@ -173,14 +174,17 @@ public AuthSession tableSession(RESTClient sharedClient, 
Map<String, String> pro
       sessionCache = newSessionCache(name, properties);
     }
 
+    String oauth2ServerUri = 
properties.get(OAuth2Properties.OAUTH2_SERVER_URI);

Review Comment:
   My rationale here is: two auth sessions for 2 different catalogs, but with 
the same credential, would be wrongly conflated since they would share the same 
cache key.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to