danielcweeks commented on code in PR #14178:
URL: https://github.com/apache/iceberg/pull/14178#discussion_r2402690097
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##########
@@ -173,14 +173,17 @@ public AuthSession tableSession(RESTClient sharedClient,
Map<String, String> pro
sessionCache = newSessionCache(name, properties);
}
+ String oauth2ServerUri =
+ properties.getOrDefault(OAuth2Properties.OAUTH2_SERVER_URI,
ResourcePaths.tokens());
Review Comment:
I'm not sure that signer endpoint works in isolation. You can have two
different tokens/sessions from two table loads and they're going to have the
same sigher uri (the uri can be the same for all signing requests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
