tomtongue opened a new pull request, #14376:
URL: https://github.com/apache/iceberg/pull/14376
## Change
The current test parameters in the `TestRewritePositionDeleteFiles` don't
match the actual test values (the details are below). So this PR tries to fix
these parameters to match the actual values, and also to parameterize the table
format version for the method `createTable`.
### Details
An example of the current test logs (each parameter name like
`formatVersion`, `catalogName` etc. doesn’t match the corresponding value as
below):
```
TestRewritePositionDeleteFiles > testDatePartition() > formatVersion =
testhive, catalogName = org.apache.iceberg.spark.SparkCatalog, implementation =
{type=hive, default-namespace=default, cache-enabled=false}, config = {3}
STANDARD_ERROR // <= not match
[Test worker] INFO org.apache.spark.sql.internal.SharedState - Setting
hive.metastore.warehouse.dir ('null') to the value of spark.sql.warehouse.dir.
[Test worker] INFO org.apache.spark.sql.internal.SharedState - Warehouse
path is 'file:/path/to/iceberg/spark/v4.0/spark-extensions/spark-warehouse'.
[Test worker] INFO org.sparkproject.jetty.server.handler.ContextHandler
- Started o.s.j.s.ServletContextHandler@708378cc{/SQL,null,AVAILABLE,@Spark}
...
```
After applying this change (each parameter name matches the corresponding
value):
```
TestRewritePositionDeleteFiles > testDatePartition() > catalogName =
testhive, implementation = org.apache.iceberg.spark.SparkCatalog, config =
{type=hive, default-namespace=default, cache-enabled=false}, formatVersion = 2
STANDARD_ERROR // <= match
[Test worker] INFO org.apache.spark.sql.internal.SharedState - Setting
hive.metastore.warehouse.dir ('null') to the value of spark.sql.warehouse.dir.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
