ebyhr commented on code in PR #14376:
URL: https://github.com/apache/iceberg/pull/14376#discussion_r2443812112
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java:
##########
@@ -85,17 +89,21 @@ public class TestRewritePositionDeleteFiles extends
ExtensionsTestBase {
private static final int DELETE_FILES_PER_PARTITION = 2;
private static final int DELETE_FILE_SIZE = 10;
- @Parameters(name = "formatVersion = {0}, catalogName = {1}, implementation =
{2}, config = {3}")
+ @Parameters(name = "catalogName = {0}, implementation = {1}, config = {2},
formatVersion = {3}")
Review Comment:
> I believe it's also possible to simply remove the formatVersion parameter
if this test is only for V2.
+1 to remove the `formatVersion` from this annotation, since we don't expect
to add a new format version here due to deletion vectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
