nastra commented on code in PR #14287:
URL: https://github.com/apache/iceberg/pull/14287#discussion_r2448554579
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -167,6 +173,17 @@ public ExpireSnapshots cleanExpiredMetadata(boolean clean)
{
return this;
}
+ @Override
+ public ExpireSnapshots cleanMode(CleanupMode mode) {
+ Preconditions.checkNotNull(mode, "CleanupMode cannot be null");
Review Comment:
```suggestion
Preconditions.checkArgument(null != mode, "Invalid cleanup mode: null");
```
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -167,6 +173,17 @@ public ExpireSnapshots cleanExpiredMetadata(boolean clean)
{
return this;
}
+ @Override
+ public ExpireSnapshots cleanMode(CleanupMode mode) {
+ Preconditions.checkNotNull(mode, "CleanupMode cannot be null");
+ Preconditions.checkArgument(
Review Comment:
same as mentioned earlier about throwing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
