amogh-jahagirdar commented on code in PR #14287:
URL: https://github.com/apache/iceberg/pull/14287#discussion_r2448581873
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
Review Comment:
I think we need early return here if cleanup mode is none
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
Review Comment:
I think we need an early return here if cleanup mode is None.
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -380,9 +399,9 @@ private void cleanExpiredSnapshots() {
FileCleanupStrategy cleanupStrategy =
incrementalCleanup
? new IncrementalFileCleanup(
- ops.io(), deleteExecutorService, planExecutorService(),
deleteFunc)
Review Comment:
I think we need an early return before this point if cleanup mode is None
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
Review Comment:
I think we need early return here if cleanup mode is none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
