danielcweeks commented on code in PR #14161:
URL: https://github.com/apache/iceberg/pull/14161#discussion_r2449093923
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOAwsClientFactory.java:
##########
@@ -44,4 +44,13 @@ public interface S3FileIOAwsClientFactory extends
Serializable {
* @param properties catalog properties
*/
void initialize(Map<String, String> properties);
+
+ /**
+ * Get the HTTP client key used for resource management.
+ *
+ * @return HTTP client key, or null if not available
+ */
+ default String httpClientKey() {
Review Comment:
I added a comment in another location, but I agree that we're leaking this
too far into the rest of the implementation. I feel like tracking of the
clients should be encapsulated into the client factory which is where the
client is being created.
Ideally, if we want to ensure that the resources are properly tracked and
closed, we would wrap the http client and ref count the close calls (I think
you alluded to this elsewhere).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
