stevenzwu commented on code in PR #14287:
URL: https://github.com/apache/iceberg/pull/14287#discussion_r2449817874
##########
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##########
@@ -129,4 +152,24 @@ default ExpireSnapshots cleanExpiredMetadata(boolean
clean) {
throw new UnsupportedOperationException(
this.getClass().getName() + " doesn't implement cleanExpiredMetadata");
}
+
+ /** An enum representing possible clean up levels used in snapshot
expiration. */
+ enum CleanupLevel {
Review Comment:
nit: we typically define the public interface/enum at the top of a class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]