nastra commented on code in PR #14387:
URL: https://github.com/apache/iceberg/pull/14387#discussion_r2451204807
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -386,29 +388,46 @@ public void testDeleteDataFile() throws Exception {
.hasSize(1);
}
- @Test
- public void testPositionDeletes() throws Exception {
+ @ParameterizedTest
+ @ValueSource(strings = {"avro", "parquet", "orc"})
Review Comment:
hm ok I see, thanks for the clarification. We should probably do the
parameterization at the class level, since we'll need to run this test class
also with different format versions. Btw there's also
https://github.com/apache/iceberg/pull/14351 that is working on some aspects of
this, so I might be good to sync up the efforts on this test class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
