nastra commented on code in PR #14387:
URL: https://github.com/apache/iceberg/pull/14387#discussion_r2454091329
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -386,29 +388,46 @@ public void testDeleteDataFile() throws Exception {
.hasSize(1);
}
- @Test
- public void testPositionDeletes() throws Exception {
+ @ParameterizedTest
+ @ValueSource(strings = {"avro", "parquet", "orc"})
Review Comment:
my main issue is that using `@ParameterizedTest` for one test and using
`@TestTemplate` (we eventually want to run this test with format version 2 and
3, which is being added by #14351) for everything else is not compatible.
Alternatively maybe do the parameterization differently by having a
`testPositionDeletes(String format)` without a `@Test` annotation and then have
`@Test testPositionDeletesWithAvro()` / `@Test
testPositionDeletesWithParquet()` which both call `testPositionDeletes(String
format)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
