pvary commented on code in PR #14414:
URL: https://github.com/apache/iceberg/pull/14414#discussion_r2459729353
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -160,12 +161,13 @@ byte[] writeToManifest(
writeResults.forEach(w -> builder.add(w.writeResult()));
WriteResult result = builder.build();
+ Table table = catalog.loadTable(TableIdentifier.parse(key.tableName()));
Review Comment:
We should cache, or make the info part of the Committable.
Committable seems like a better choice, as the serialized manifest file is
different for the 2 versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
