Guosmilesmile commented on code in PR #14414:
URL: https://github.com/apache/iceberg/pull/14414#discussion_r2514153856


##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -145,6 +147,18 @@ private <T extends ContentFile<T>> PartitionSpec 
readPartitionSpec(InputFile inp
     return PartitionSpecParser.fromJsonFields(schema, specId, 
metadata.get("partition-spec"));
   }
 
+  private int readFormatVersion(InputFile inputFile) {
+    Map<String, String> metadata = readMetadata(inputFile);

Review Comment:
   I tried to obtain this information through other methods, but later found 
that only the Position delete file has changes in versions V2 and V3. In V3 
need  DVS, so afterwards I changed the approach to first determine based solely 
on the type of delete files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to