kevinjqliu commented on code in PR #2601: URL: https://github.com/apache/iceberg-python/pull/2601#discussion_r2464137001
########## pyproject.toml: ########## @@ -14,111 +14,163 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -[tool.poetry] +[project] name = "pyiceberg" version = "0.10.0" -readme = "README.md" -homepage = "https://py.iceberg.apache.org/"; -repository = "https://github.com/apache/iceberg-python"; description = "Apache Iceberg is an open table format for huge analytic datasets" -authors = ["Apache Software Foundation <[email protected]>"] -license = "Apache License 2.0" +authors = [{ name = "Apache Software Foundation", email = "[email protected]" }] +requires-python = ">=3.9.2,<4.0.0,!=3.9.7" Review Comment: ```suggestion requires-python = ">=3.10,<4.0.0" ``` we just removed 3.9 in #2554 ########## .github/workflows/svn-build-artifacts.yml: ########## @@ -47,13 +47,13 @@ jobs: 3.11 3.12 - - name: Install poetry - run: make install-poetry + - name: Install UV + run: make install-uv Review Comment: i think we need to use ``` - name: Install uv uses: astral-sh/setup-uv@v6 ``` instead of `make install-uv` When i was testing "Nightly PyPI Build", `make install-uv` fails for windows machine with ``` Run uv version "0.10.0.dev20251026230001" uv: D:\a\_temp\c958d63c-abd9-4fae-8896-0d96857f661f.ps1:2 Line | 2 | uv version "0.10.0.dev20251026230001" | ~~ | The term 'uv' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the | spelling of the name, or if a path was included, verify that the path is correct and try again. Error: Process completed with exit code 1. ``` https://github.com/kevinjqliu/iceberg-python/actions/runs/18824958012/job/53706130681 ########## pyproject.toml: ########## @@ -14,111 +14,163 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -[tool.poetry] +[project] name = "pyiceberg" version = "0.10.0" -readme = "README.md" -homepage = "https://py.iceberg.apache.org/"; -repository = "https://github.com/apache/iceberg-python"; description = "Apache Iceberg is an open table format for huge analytic datasets" -authors = ["Apache Software Foundation <[email protected]>"] -license = "Apache License 2.0" +authors = [{ name = "Apache Software Foundation", email = "[email protected]" }] +requires-python = ">=3.9.2,<4.0.0,!=3.9.7" +readme = "README.md" +license = "Apache-2.0" classifiers = [ - "License :: OSI Approved :: Apache Software License", - "Operating System :: OS Independent", - "Programming Language :: Python :: 3.9", - "Programming Language :: Python :: 3.10", - "Programming Language :: Python :: 3.11", - "Programming Language :: Python :: 3.12", + "License :: OSI Approved :: Apache Software License", + "Operating System :: OS Independent", + "Programming Language :: Python :: 3.9", Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
