kevinjqliu commented on code in PR #2601:
URL: https://github.com/apache/iceberg-python/pull/2601#discussion_r2500881417
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,13 +70,15 @@ jobs:
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10"
CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_TEST_COMMAND: "PYTHON_GIL=1 pytest
{project}/tests/avro/test_decoder.py"
+ CIBW_BUILD_VERBOSITY: 1
Review Comment:
```suggestion
```
nit: i dont think we need this
##########
pyproject.toml:
##########
@@ -291,43 +317,6 @@ ignore_missing_imports = true
module = "google.*"
ignore_missing_imports = true
-[tool.poetry.scripts]
-pyiceberg = "pyiceberg.cli.console:run"
-
-[build-system]
-requires = ["poetry-core>=1.0.0", "wheel", "Cython>=3.0.0", "setuptools"]
-build-backend = "poetry.core.masonry.api"
-
-[tool.poetry.build]
-generate-setup-file = false
-script = "build-module.py"
-
-[tool.poetry.extras]
-pyarrow = ["pyarrow", "pyiceberg-core"]
-pandas = ["pandas", "pyarrow"]
-duckdb = ["duckdb", "pyarrow"]
-ray = ["ray", "pyarrow", "pandas"]
-bodo = ["bodo"]
-daft = ["daft"]
-polars = ["polars"]
-snappy = ["python-snappy"]
-hive = ["thrift"]
-hive-kerberos = ["thrift", "thrift_sasl", "kerberos"]
-s3fs = ["s3fs"]
-glue = ["boto3"]
-adlfs = ["adlfs"]
-dynamodb = ["boto3"]
-bigquery = ["google-cloud-bigquery"]
-zstandard = ["zstandard"]
-sql-postgres = ["sqlalchemy", "psycopg2-binary"]
-sql-sqlite = ["sqlalchemy"]
-gcsfs = ["gcsfs"]
-rest-sigv4 = ["boto3"]
-hf = ["huggingface-hub"]
-pyiceberg-core = ["pyiceberg-core"]
-datafusion = ["datafusion"]
-gcp-auth = ["google-auth"]
-
[tool.pytest.ini_options]
testpaths = ["tests"]
Review Comment:
```suggestion
testpaths = ["tests"]
pythonpath = ["."]
```
had to add this for `make test` to work locally
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,13 +70,15 @@ jobs:
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10"
CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_TEST_COMMAND: "PYTHON_GIL=1 pytest
{project}/tests/avro/test_decoder.py"
Review Comment:
```suggestion
CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
```
do we need this? since we added `CIBW_SKIP: "cp3*t-*"` below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
