smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2467103538
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -305,6 +418,8 @@ public LocationProvider locationProvider() {
@Override
public FileIO io() {
+ // TODO(smaheshwar-pltr): Hive fetches encryption props here from
uncommitted metadata
+ //
RESTTableOperations.this.encryptionPropsFromMetadata(uncommittedMetadata);
Review Comment:
I think the Hive table operations are a bit different in how they handle
things. Commenting this out on the Hive side causes the new CTAS to fail for
Hive, and _leaving this in_ for REST causes that test to fail.
I believe the temporary operations using the same IO should not be
problematic and the constructor that initialises the encryption props with the
`LoadTableResponse` metadata means that things work here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
