smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2467174799
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -115,14 +146,25 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
Consumer<ErrorResponse> errorHandler;
List<UpdateRequirement> requirements;
List<MetadataUpdate> updates;
+
+ TableMetadata metadataToCommit = metadata;
+ if (encryption() instanceof StandardEncryptionManager) {
+ TableMetadata.Builder builder = TableMetadata.buildFrom(metadata);
+ for (Map.Entry<String, EncryptedKey> entry :
+ EncryptionUtil.encryptionKeys(encryption()).entrySet()) {
+ builder.addEncryptionKey(entry.getValue());
Review Comment:
Pointing out that this adds the required REST updates to the metadata to be
committed. I _think_ that additional REST requirements for these keys are not
be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
