blcksrx commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r2478101520


##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -48,6 +49,23 @@ private CatalogProperties() {}
 
   public static final boolean CACHE_CASE_SENSITIVE_DEFAULT = true;
 
+  /**
+   * Controls policy of caffeine cache
+   *
+   * <p>Behavior of specific values of cache.strategy:
+   *
+   * <ul>
+   *   <li>EXPIRE_AFTER_ACCESS - cache entries are never evicted as long as 
they are being accessed
+   *       frequently
+   *   <li>EXPIRE_AFTER_WRITE - cache entries are evicted frequently after 
cache write
+   * </ul>
+   */
+  public static final String CACHE_POLICY = "cache.strategy";
+
+  public static final List<String> CACHE_POLICY_VALUES =

Review Comment:
   Regarding being enum at first glance, I went for enum but I saw there is no 
support for Enums in the PropertyUtils. that's why I have sticked with the 
String



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to