Tommo56700 commented on PR #14440: URL: https://github.com/apache/iceberg/pull/14440#issuecomment-3487823162
Looking good, I do have a couple of questions. Would it make sense to provide the same extension to the executor cache? https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkExecutorCache.java#L164 Also, not sure on the etiquette in this repository, but it might be appropriate to tag some of the original reviewers from this PR - they might have some more context/opinions on how this should take shape https://github.com/apache/iceberg/pull/3543 I also quite like your suggestion of a pluggable caching strategy, but I think it is great to introduce some standard defaults for now and should solve my use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
