zhjwpku commented on code in PR #286:
URL: https://github.com/apache/iceberg-cpp/pull/286#discussion_r2484842414


##########
src/iceberg/table_requirement.cc:
##########
@@ -54,7 +54,24 @@ Status AssertLastAssignedFieldId::Validate(const 
TableMetadata* base) const {
 }
 
 Status AssertCurrentSchemaID::Validate(const TableMetadata* base) const {
-  return NotImplemented("AssertCurrentTableSchemaID::Validate not 
implemented");
+  // Validate that the current schema ID matches the expected value

Review Comment:
   ```suggestion
     // Validate that the current schema ID matches the one used when the 
metadata was read
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to