zhjwpku commented on code in PR #280:
URL: https://github.com/apache/iceberg-cpp/pull/280#discussion_r2484860549
##########
src/iceberg/expression/predicate.cc:
##########
@@ -287,10 +307,10 @@ BoundPredicate::BoundPredicate(Expression::Operation op,
std::shared_ptr<BoundTe
BoundPredicate::~BoundPredicate() = default;
-Result<Literal::Value> BoundPredicate::Evaluate(const StructLike& data) const {
+Result<Literal> BoundPredicate::Evaluate(const StructLike& data) const {
Review Comment:
We don't have that yet, which seems fine at this early stage of iceberg-cpp,
but we should follow [semantic versioning](https://semver.org/) once the
project becomes stable, i.e. bump up major version for incompatible API
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
