wgtmac commented on code in PR #280:
URL: https://github.com/apache/iceberg-cpp/pull/280#discussion_r2486989604
##########
src/iceberg/expression/predicate.cc:
##########
@@ -331,12 +376,91 @@
BoundLiteralPredicate::BoundLiteralPredicate(Expression::Operation op,
BoundLiteralPredicate::~BoundLiteralPredicate() = default;
-Result<bool> BoundLiteralPredicate::Test(const Literal::Value& value) const {
- return NotImplemented("BoundLiteralPredicate::Test not implemented");
+Result<bool> BoundLiteralPredicate::Test(const Literal& value) const {
Review Comment:
Comparing nulls returns `std::partial_ordering::unordered` so it is
automatically `false`:
https://github.com/apache/iceberg-cpp/blob/main/src/iceberg/expression/literal.cc#L358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
