kamcheungting-db commented on code in PR #14479:
URL: https://github.com/apache/iceberg/pull/14479#discussion_r2485320459
##########
aws/src/main/java/org/apache/iceberg/aws/RESTSigV4AuthSession.java:
##########
@@ -56,6 +55,7 @@ public class RESTSigV4AuthSession implements AuthSession {
static final String EMPTY_BODY_SHA256 =
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855";
static final String RELOCATED_HEADER_PREFIX = "Original-";
+ private static final String X_AMZ_CONTENT_SHA256 = "x-amz-content-sha256";
Review Comment:
make it public and utilize this one the test case above.
```suggestion
static final String X_AMZ_CONTENT_SHA256 = "x-amz-content-sha256";
```
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -394,15 +393,15 @@ protected String calculateContentHash(
SdkChecksum contentFlexibleChecksum) {
boolean isUnsignedStreamingTrailer =
mutableRequest
- .firstMatchingHeader(SignerConstant.X_AMZ_CONTENT_SHA256)
+ .firstMatchingHeader("x-amz-content-sha256")
Review Comment:
could you define
```suggestion
.firstMatchingHeader(X_AMZ_CONTENT_SHA256)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
