kamcheungting-db commented on code in PR #14479:
URL: https://github.com/apache/iceberg/pull/14479#discussion_r2485320839
##########
aws/src/test/java/org/apache/iceberg/aws/TestRESTSigV4Signer.java:
##########
@@ -111,8 +110,7 @@ public void signRequestWithoutBody() {
"Bearer existing_token"))
// Require the empty body checksum
.withHeader(
- Header.header(
- SignerConstant.X_AMZ_CONTENT_SHA256,
RESTSigV4AuthSession.EMPTY_BODY_SHA256));
+ Header.header("x-amz-content-sha256",
RESTSigV4AuthSession.EMPTY_BODY_SHA256));
Review Comment:
```suggestion
Header.header(X_AMZ_CONTENT_SHA256,
RESTSigV4AuthSession.EMPTY_BODY_SHA256));
```
##########
aws/src/test/java/org/apache/iceberg/aws/TestRESTSigV4Signer.java:
##########
@@ -144,7 +142,7 @@ public void signRequestWithBody() {
RESTSigV4AuthSession.RELOCATED_HEADER_PREFIX +
HttpHeaders.AUTHORIZATION,
"Bearer existing_token"))
// Require a body checksum is set
- .withHeader(Header.header(SignerConstant.X_AMZ_CONTENT_SHA256));
+ .withHeader(Header.header("x-amz-content-sha256"));
Review Comment:
```suggestion
.withHeader(Header.header(X_AMZ_CONTENT_SHA256));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
