joyhaldar commented on PR #14447: URL: https://github.com/apache/iceberg/pull/14447#issuecomment-3480829250
> @joyhaldar Thanks for working at this! I think service account impersonation is relevant also outside of the BigQueryMetastoreCatalog context - basically for every workload running on GCP, so I would just make sure it's generic enough to be used regardless of the catalog type Hi @yogevyuval, Thanks for the feedback! I really appreciate it. I wrote this to follow current patterns, for example [AssumeRoleAwsClientFactory](https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/S3FileIOAwsClientFactories.java) also only works with AWS catalogs if I am not wrong (please correct me if I am). I also think that users can handle impersonation at the application level for other catalog types if needed. I personally think this would be best addressed in a follow-up PR to keep the scope focused, but I'm happy to try and expand this PR to support any catalog now if you and the other reviewers think that's a good idea. Please let me know what you think. Thanks, Joy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
