kevinjqliu commented on PR #14447: URL: https://github.com/apache/iceberg/pull/14447#issuecomment-3504670549
Is the service account impersonation support for the catalog, fileio, or both? I see there's already a [GoogleAuthManager class](https://github.com/apache/iceberg/blob/main/gcp/src/main/java/org/apache/iceberg/gcp/auth/GoogleAuthManager.java) for handling auth and google credential. It uses [GoogleCredentials.fromStream](https://github.com/apache/iceberg/blob/8da07dcae8ccf5ce1a0c61a7456413c1ce3b65fd/gcp/src/main/java/org/apache/iceberg/gcp/auth/GoogleAuthManager.java#L87) which already [supports ImpersonatedCredentials](https://github.com/googleapis/google-auth-library-java/blob/a65c22da2c93bdf33dcd98ece47ee6668d1ed32c/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java#L324-L326) Could we reuse the GoogleAuthManager to abstract away the auth details? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
