nandorKollar commented on PR #14499: URL: https://github.com/apache/iceberg/pull/14499#issuecomment-3486519865
Is there any way to cover this with tests? One option I can think of is to add a test case to Spark where we write the file with `spark.sql.parquet.outputTimestampType=TIMESTAMP_MILLIS`, and try to read it back via Arrow batch reader. An other idea, which came to my mind is that restructure the code, handle the special case where Iceberg type is timestamp, but the Parquet type is TIMESTAMP_MILLIS, then we can write a simple test case for that in `ArrowSchemaUtil`. Not sure if this is a good idea, just a thought. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
