pvary commented on code in PR #14499:
URL: https://github.com/apache/iceberg/pull/14499#discussion_r2491277461
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -541,31 +541,41 @@ public Optional<LogicalTypeVisitorResult> visit(
@Override
public Optional<LogicalTypeVisitorResult> visit(
LogicalTypeAnnotation.TimestampLogicalTypeAnnotation
timestampLogicalType) {
- FieldVector vector = arrowField.createVector(rootAlloc);
switch (timestampLogicalType.getUnit()) {
case MILLIS:
- ((BigIntVector) vector).allocateNew(batchSize);
+ Field bigIntField =
+ new Field(
+ icebergField.name(),
+ new FieldType(
+ icebergField.isOptional(), new ArrowType.Int(Long.SIZE,
true), null, null),
+ null);
+ FieldVector millisVector = bigIntField.createVector(rootAlloc);
+ ((BigIntVector) millisVector).allocateNew(batchSize);
Review Comment:
That's a good point! How will the caller know what is the vector type in
this case? When will the caller get a BigIntVector for a timestamp, and when
will it get a TimeStampMilliTZVector?
I think if this was never working before, most probably a
TimeStampMilliTZVector would be a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
