rdblue commented on code in PR #14509: URL: https://github.com/apache/iceberg/pull/14509#discussion_r2496233053
########## api/src/main/java/org/apache/iceberg/SnapshotUpdateValidator.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.function.BiConsumer; + +/** + * Interface to support validating snapshots during the commit process. + * + * <p>Validation will be called after the table metadata is refreshed but before the updates are + * committed to the table. + */ +@FunctionalInterface +public interface SnapshotUpdateValidator + extends BiConsumer<Iterable<Snapshot>, Iterable<Snapshot>> { Review Comment: I would expect validation to be a bit more explicit, like a `BiFunction<Iterable<Snapshot>, Iterable<Snapshot>, Boolean>` so that it has to return that the changes are either valid or invalid. Since this is wrapping a function, we can still pass an error message by adding a `String errorMessage()` function. That would also allow Iceberg to control the exception type that is thrown (`ValidationException`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
