danielcweeks commented on code in PR #14509:
URL: https://github.com/apache/iceberg/pull/14509#discussion_r2496410079
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -459,6 +467,23 @@ public void commit() {
return;
}
+ // Pass the snapshot ancestry of the base and the updated
snapshots to the
+ // validator.
+ String validationBranch =
Review Comment:
I disagree with this since the original `validate` call is called before we
build the new update. As a generalized API for validating the snapshots
pre-commit, we really need to expose the ability to inspect what is planned to
be committed.
The KC case only looks at the prior state, but I don't think we should focus
so narrowly on that scenario. It's likely a validation may include inspection
of the new state as well (or compare that with existing state). If we were
only going to pass one, I think it would be the updated state, since you can
mostly look back (though snapshots may have been removed, so you don't have a
full picture without both).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
