pvary commented on code in PR #13786:
URL: https://github.com/apache/iceberg/pull/13786#discussion_r2504536430
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1537,6 +1575,20 @@ public <D> CloseableIterable<D> build() {
}
}
+ private static VectorizedParquetReaderFactory loadReaderFactory(String name)
{
+ ServiceLoader<VectorizedParquetReaderFactory> loader =
Review Comment:
Here is Ryan's comment about using ServiceLoader:
https://github.com/apache/iceberg/pull/12060#discussion_r1938350796
> The ServiceLoader framework is error prone and commonly broken because of
Jar bundling.
Here he refers to the case when creating an uber-jar the files in the
`META-INF/services/` directory are often removed/forgotten/overwrite each other
which causes issues when trying to access the service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
