parthchandra commented on code in PR #13786:
URL: https://github.com/apache/iceberg/pull/13786#discussion_r2504620910
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1537,6 +1575,20 @@ public <D> CloseableIterable<D> build() {
}
}
+ private static VectorizedParquetReaderFactory loadReaderFactory(String name)
{
+ ServiceLoader<VectorizedParquetReaderFactory> loader =
Review Comment:
The goal here was to decouple the vectorized parquet reader from the common
code and `ServiceLoader` merely simplifies the dynamic loading of the service
(in this case the reader). We could use some other mechanism like specifying
the actual reader class as a config. This puts the onus on to the user to
specify the class correctly and ensure it is on the classpath.
Let me change this to specify the class explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
