XJDKC commented on code in PR #14465:
URL: https://github.com/apache/iceberg/pull/14465#discussion_r2505148971
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -63,13 +65,28 @@ public RESTCatalog() {
}
public RESTCatalog(Function<Map<String, String>, RESTClient> clientBuilder) {
- this(SessionCatalog.SessionContext.createEmpty(), clientBuilder);
+ this(SessionCatalog.SessionContext.createEmpty(), clientBuilder, null,
null);
}
public RESTCatalog(
SessionCatalog.SessionContext context,
Function<Map<String, String>, RESTClient> clientBuilder) {
- this.sessionCatalog = new RESTSessionCatalog(clientBuilder, null);
+ this(context, clientBuilder, null, null);
+ }
+
+ public RESTCatalog(
+ Function<Map<String, String>, RESTClient> clientBuilder,
+ BiFunction<SessionCatalog.SessionContext, Map<String, String>, FileIO>
ioBuilder,
+ RESTOperationsBuilder operationsBuilder) {
+ this(SessionCatalog.SessionContext.createEmpty(), clientBuilder,
ioBuilder, operationsBuilder);
+ }
Review Comment:
Even though RESTSessionCatalog allows us to pass in the ioBuilder, but the
RESTCatalog doesn't, so I add it in the constructor of RESTCatalog as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
