XJDKC commented on code in PR #14465:
URL: https://github.com/apache/iceberg/pull/14465#discussion_r2505182845
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -44,10 +44,10 @@
import org.apache.iceberg.rest.responses.LoadTableResponse;
import org.apache.iceberg.util.LocationUtil;
-class RESTTableOperations implements TableOperations {
+public class RESTTableOperations implements TableOperations {
Review Comment:
If users only want to make small adjustments to RESTTableOperations (for
example, injecting a custom header), they can simply provide a custom
implementation that extends RESTTableOperations, without having to copy the
entire class.
This makes it much easier for them to upgrade to newer Iceberg SDK versions
without dealing with merge conflicts or duplicated code.
I'm okay with either approach here, don't have a strong preference. WDYT?
##########
core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java:
##########
@@ -29,14 +29,14 @@
import org.apache.iceberg.view.ViewMetadata;
import org.apache.iceberg.view.ViewOperations;
-class RESTViewOperations implements ViewOperations {
+public class RESTViewOperations implements ViewOperations {
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
