smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2505910101
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -241,12 +328,38 @@ private static Long
expectedSnapshotIdIfSnapshotAddOnly(List<MetadataUpdate> upd
return addedSnapshotId;
}
+ private void encryptionPropsFromMetadata(TableMetadata metadata) {
+ if (metadata == null || metadata.properties() == null) {
+ return;
+ }
+
+ encryptedKeysFromMetadata = metadata.encryptionKeys();
+
+ Map<String, String> tableProperties = metadata.properties();
+ if (tableKeyId == null) {
+ tableKeyId = tableProperties.get(TableProperties.ENCRYPTION_TABLE_KEY);
+ }
+
+ if (tableKeyId != null && encryptionDekLength <= 0) {
+ String dekLength =
tableProperties.get(TableProperties.ENCRYPTION_DEK_LENGTH);
+ encryptionDekLength =
+ (dekLength == null)
+ ? TableProperties.ENCRYPTION_DEK_LENGTH_DEFAULT
+ : Integer.parseInt(dekLength);
Review Comment:
Agree, cc @ggershinsky maybe similar situation to
https://github.com/apache/iceberg/pull/13225#discussion_r2505900224.
(Happy to think / put up these patches if it'd help, but the original code
is @ggershinsky's so will wait 🙏)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
