ggershinsky commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2507975973
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -115,14 +146,25 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
Consumer<ErrorResponse> errorHandler;
List<UpdateRequirement> requirements;
List<MetadataUpdate> updates;
+
+ TableMetadata metadataToCommit = metadata;
+ if (encryption() instanceof StandardEncryptionManager) {
Review Comment:
A couple of points,
1. The stated requirement is to "check that the base metadata is current to
avoid overwriting updates". This is met. We add a missing field to the new
metadata after the check.
2. There are lots of calls to `commit` from various classes. Moving this
outside will be technically hard (if it works at all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
