amogh-jahagirdar commented on code in PR #14480:
URL: https://github.com/apache/iceberg/pull/14480#discussion_r2510274037
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -91,13 +96,16 @@ public class RESTCatalogAdapter extends BaseHTTPClient {
.put(CommitFailedException.class, 409)
.put(UnprocessableEntityException.class, 422)
.put(CommitStateUnknownException.class, 500)
+ .put(NoSuchPlanIdException.class, 404)
+ .put(NoSuchPlanTaskException.class, 404)
.buildOrThrow();
private final Catalog catalog;
private final SupportsNamespaces asNamespaceCatalog;
private final ViewCatalog asViewCatalog;
private AuthSession authSession = AuthSession.EMPTY;
+ private final PlanningBehavior planningBehavior = planningBehavior();
Review Comment:
Yeah, we are planning to override this in `CatalogTests` so that we can
override with a smaller amount of tasks per plan task (the default is 100, just
a number that felt reasonable in case someone wanted to setup some basic
catalog using RESTCatalogAdapter) . Also we plan on deterministically override
when planning should be done async; this structure makes it easier to setup the
tests then so we can deterministically exercise all parts of the protocol in
the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
